Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests for the partner access service #227

Open
eleanorreem opened this issue Nov 23, 2022 · 4 comments
Open

Write tests for the partner access service #227

eleanorreem opened this issue Nov 23, 2022 · 4 comments
Assignees
Labels
complexity: moderate Time needed to do this ticket will be moderate e.g. 1-2 days help wanted Extra attention is needed software testing Software testing stale This issue or PR is inactive.

Comments

@eleanorreem
Copy link
Contributor

eleanorreem commented Nov 23, 2022

Background
We want to have a more robust code base. When bloom was developed it was not thoroughly tested and we are trying to fill in the gaps.

Task

  • write tests for /src/partner-access/partner-access.service.spec.ts.
  • the file has already been created and a couple of tests have been started in src/partner-access/partner-access.service.spec.ts
  • if you see logic in the code that doesn't make sense or can be improved, let @swetha-charles or @eleanorreem know as it is possible that the logic is wrong and create a bug report.

Possible test scenarios

  • a partnerAdmin fails to create a partner access code as the partner doesn't exist
  • a user cannot assign an access code to their account as the user doesn't exist
  • a user cannot assign an access code to their account as the partner doesn't exist
  • a user successfully assigns partner access codes on sign up
  • a user fails to assign partner access code on sign up
@swetha-charles swetha-charles added the complexity: moderate Time needed to do this ticket will be moderate e.g. 1-2 days label Nov 23, 2022
@kyleecodes kyleecodes added software testing Software testing hacktoberfest Hacktoberfest issues labels Sep 28, 2023
@kyleecodes kyleecodes removed the hacktoberfest Hacktoberfest issues label Nov 3, 2023
@kyleecodes kyleecodes added the help wanted Extra attention is needed label Mar 25, 2024
@haydnba
Copy link

haydnba commented May 28, 2024

I would be interested in working on this

Copy link

Thank you for your interest in contributing to Chayn! Please carefully read the CONTRIBUTING.md file and the README.md file for guidance. Let us know if you have any questions. Good luck!

@kyleecodes
Copy link
Member

@haydnba you are assigned!

Copy link

github-actions bot commented Jun 1, 2024

As per Chayn policy, after 60 days of inactivity, we will be unassigning this issue to open it back up for contributors. Please comment to be re-assigned. Thank you for your interest in contributing to Chayn!

@github-actions github-actions bot added the stale This issue or PR is inactive. label Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: moderate Time needed to do this ticket will be moderate e.g. 1-2 days help wanted Extra attention is needed software testing Software testing stale This issue or PR is inactive.
Projects
Development

No branches or pull requests

4 participants